fix helm test --logs command throws exception #8396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/S
Cweiping
force-pushed
the
fix/fix_helm_test_not_get_pod_log_of_job
branch
from
a368712
to
a62e423
Compare
|
please write a test to cover this case. Thanks. |
Signed-off-by: Weiping Cai <weiping.cai@daocloud.io>
Cweiping
force-pushed
the
fix/fix_helm_test_not_get_pod_log_of_job
branch
from
a62e423
to
9d92428
Compare
helm-bot
added
size/M
I tried to write UT for a while, but I didn't feel right. I hope to get your suggestions. Then there is a bug in mock pod log and I need to wait for a release：kubernetes/kubernetes#92952 |
5 tasks
|
does this PR still continue to update? |
|
@Cweiping Are you still working on this? If not maybe someone else can help push this forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the kind type of hook that does not support throwing exceptions
Support the job type to obtain its log
I tried to solve those issue : #8342 、#8018 、#6968.
If not, please give me some advice.Thx!
Special notes for your reviewer:
If applicable: