-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install chart from registry #6982
Comments
Hi @JulienBreux! Yes, we would be happy to accept a PR to support this. Internally, charts are fetched from APIs (such as the chart repository API) using a getter interface. We don't have one available for the OCI spec. Let us know if you'd like to implement this functionality. See also #6593 |
Thanks @bacongobbler for your reply. Let's go! But a question, you prefer |
My first impression would be to implement as Before we get too ahead of ourselves, I'd look at implementing an internal getter that supports the OCI distribution specification. That way the groundwork can be laid out first. Have a look at |
This is much needed. What's unclear is how we shall determine if the ref is to be treated as a 1.) local dir 2.) remote repo-based chart 3.) locally cached/remote registry-based chart We could require a prefix such as Alternatively, we could require that a tag be provided. Then we can check for the The |
i'd suggest the git method: for the actual complete install command, i'd strongly suggest combining it with the normal install (if only to avoid possibile logic duplication):
this would also shrink down adjustment efforts for anyone using the repo way. the HELM_EXPERIMENTAL_OCI check would have to be on that specific chart source option then. unfortunately i don't know go :( edit: mixed upgrade/install up |
This feature is very needed! And I noticed that you've already created a PR before but not been merged. So, what I've missed? @JulienBreux |
See #6593. |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
/remove stale |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
/remove stale |
I believe this has been implemented in #8843. Can you please follow the documentation and check back with your results? |
@bacongobbler I can't find the documentation, but I tried the following using helm 3.5.2:
Is this the correct way to use install/upgrade with the oci repositories? |
Try omitting the tag in the repository name. If you need a specific version, try specifying it with the --version flag. |
I'm seeing the same error, using helm 3.5.2 with Azure container registry. When I use the --version flag:
|
Hi, could you elaborate the differences between these two values? |
same problem for me in helm v3.5.3. doing the pull works: using the oci://my-registry/my-chart:1.0.0 syntax on either gives the nvalid memory address or nil pointer dereference message as mentioned. for now i will just pull and then install from local as a two step process but would love to know if/when this has been fixed |
Makes sense thanks! Does this also extend to a helm install where Chart.yaml dependencies are oci://whatever ? |
No. As mentioned before, If you're having issues with OCI dependencies and |
For me, doing the pull while using the tag instead of the version works. |
Any progress on implementing |
Any update? :) Would be nice to have this and maybe also support in the terraform |
See #9782. |
@JulienBreux why was this closed? 🤔 |
Because a PR was opened to resolve this issue and implement this feature. Ref. #9782 |
@JulienBalestra shouldn't the issue be closed when the PR is reviewed and merged in? |
Hi dream team community!
This is a little feature request: Install chart from registry
Before
After
— or —
Now
I need your comments. And I want to know if you want help to create this?
/label feature
The text was updated successfully, but these errors were encountered: