Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"helm install --description" flag not available #7033

Closed
juanmatias opened this issue Nov 20, 2019 · 4 comments · Fixed by #7074
Closed

"helm install --description" flag not available #7033

juanmatias opened this issue Nov 20, 2019 · 4 comments · Fixed by #7074
Labels

Comments

@juanmatias
Copy link
Contributor

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.11-eks-5876d6", GitCommit:"5876d6b7429820450950ade17fe7b4bf5ccada7f", GitTreeState:"clean", BuildDate:"2019-09-24T20:54:25Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
any of them

Steps to reproduce the issue
Just run:

helm install ... --description "your description" ...

Actual behavior
I get this error:
Error: unknown flag: --description

Expected behavior
As for Helm2 I need to add a description to my release.

Additional

I don't know if there is an equivalent flag on Helm 3. I couldn't find anything on the internet.

If there is a command to add description please let me know. If there is not, isn't it a desirable feature?

Thanks.

@bacongobbler
Copy link
Member

It shouldn't be all that difficult to port #3825 over to Helm 3. Feel like taking this one on?

@juanmatias
Copy link
Contributor Author

@bacongobbler I can give it a try... I'm not a go developer but I have the will... so, any advice is welcome.

@bacongobbler
Copy link
Member

The developer guide should be a helpful resource. https://helm.sh/docs/community/developers/

Let us know how you get along.

juanmatias added a commit to juanmatias/helm that referenced this issue Nov 25, 2019
…and 'helm uninstall'

When added, this flag allow us to add a custom description to the release. E.g. '--description "my custom description"'

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
@juanmatias
Copy link
Contributor Author

Ok, I did it, added flag to install, upgrade and delete.

Hope it is ok. :)

juanmatias added a commit to juanmatias/helm that referenced this issue Nov 25, 2019
Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
juanmatias added a commit to juanmatias/helm that referenced this issue Nov 25, 2019
Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
bacongobbler pushed a commit that referenced this issue Dec 9, 2019
* fix(helm): add --description flag to 'helm install', 'helm upgrade', and 'helm uninstall'

When added, this flag allow us to add a custom description to the release. E.g. '--description "my custom description"'

Closes #7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

* fix(helm): fixed style issues on top of previous commit (3a43a9a)

Closes #7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

*  fix(helm): fixed wrong test issue on top of previous commit (3a43a9a)

Closes #7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
bamachrn pushed a commit to bamachrn/helm that referenced this issue Feb 28, 2020
* fix(helm): add --description flag to 'helm install', 'helm upgrade', and 'helm uninstall'

When added, this flag allow us to add a custom description to the release. E.g. '--description "my custom description"'

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

* fix(helm): fixed style issues on top of previous commit (helm@3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

*  fix(helm): fixed wrong test issue on top of previous commit (3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
bamachrn pushed a commit to bamachrn/helm that referenced this issue Feb 28, 2020
* fix(helm): add --description flag to 'helm install', 'helm upgrade', and 'helm uninstall'

When added, this flag allow us to add a custom description to the release. E.g. '--description "my custom description"'

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

* fix(helm): fixed style issues on top of previous commit (helm@3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

*  fix(helm): fixed wrong test issue on top of previous commit (3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
bamachrn pushed a commit to bamachrn/helm that referenced this issue Feb 28, 2020
* fix(helm): add --description flag to 'helm install', 'helm upgrade', and 'helm uninstall'

When added, this flag allow us to add a custom description to the release. E.g. '--description "my custom description"'

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

* fix(helm): fixed style issues on top of previous commit (helm@3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>

*  fix(helm): fixed wrong test issue on top of previous commit (3a43a9a)

Closes helm#7033

Signed-off-by: Juan Matias Kungfu de la Camara Beovide <juanmatias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants