Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce semver semantics #72

Closed
2 tasks
jackgr opened this issue Nov 13, 2015 · 1 comment
Closed
2 tasks

Enforce semver semantics #72

jackgr opened this issue Nov 13, 2015 · 1 comment

Comments

@jackgr
Copy link
Contributor

jackgr commented Nov 13, 2015

Automated tests should assert invariants about the chart version associated with a pull request in kubernetes/charts.

  • Automated tests should fail a pull request that doesn't satisfy semver semantics. This requriement ensures that only valid builds can be used to satisfy references.
  • Automated tests should fail a pull request that changes an existing version. In other words, it should ensure that versions are immutable. For example, if you have already committed v1.2.0, you can commit v1.2.1, v1.2.2, v1.3.0 or v2.0.0, but you can't change v1.2.0. This requirement guarantees that a dependency on a fully specified three part version number can't break you by changing out from under you.
@jackgr
Copy link
Contributor Author

jackgr commented Nov 14, 2015

Depends on #68

@jackgr jackgr modified the milestone: Sprint 14 Jan 4, 2016
@jackgr jackgr added the helm label Jan 4, 2016
@jackgr jackgr modified the milestones: Sprint 14, Sprint 15 Jan 27, 2016
@jackgr jackgr modified the milestones: Sprint 15, Sprint 16 Feb 8, 2016
@jackgr jackgr modified the milestones: Sprint 16, Sprint 17 Feb 25, 2016
@jackgr jackgr modified the milestone: Sprint 17 Mar 8, 2016
@jackgr jackgr changed the title The type registry should enforce semver semantics Implement and enforce semver semantics Apr 11, 2016
@jackgr jackgr added area/test and removed helm labels Apr 11, 2016
@jackgr jackgr changed the title Implement and enforce semver semantics Enforce semver semantics Apr 11, 2016
MichaelMorrisEst pushed a commit to Nordix/helm that referenced this issue Nov 17, 2023
@mumoshu
Merge pull request helm#72 from cmeury/add-tests
a33d111 
describing current functionality of helmexec as tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@technosophos @jackgr