Add a flag to execute chart hooks in parallel #7763
Comments
|
I'd like to take a shot at implementing this if there are no immediate objections. |
|
Go for it @akhilles |
|
Same thing as #7241 |
|
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
abaehremc
added a commit
to abaehremc/helm
that referenced
this issue
Oct 27, 2020
Enables parallel execution of chart hooks. --hook-parallelism defaults to 1 to make this an opt-in feature. Batching is used to comply with "helm.sh/hook-weight" annotations. A semaphore is used to limit parallelism to the user-provided value. Some additional synchronization was necessary to run cfg.recordRelease() in a thread-safe manner. Based off of helm#7792 by akhilles. Closes helm#7763. Signed-off-by: Andrew Baehre <abaehre@morningconsult.com>
3 tasks
|
Just in case, the discussion of this issue is moved to the community proposals and here is my last comment that suggest a simple way to solve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, all chart hooks are executed serially. For some use cases (such as running
helm testin CI environments), this is just too slow. In Helm v2, thehelm testcommand supports the--paralleland--maxflags which enable and limit parallel execution of tests, respectively. This functionality wasn't ported to Helm v3 due to test infrastructure changes.Adding a
--parallelismflag to Helm v3 that allows for hooks to be executed in parallel (while still respecting"helm.sh/hook-weight"annotations) would be really useful.The text was updated successfully, but these errors were encountered: