Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template registry to its own repository #82

Closed
jackgr opened this issue Nov 16, 2015 · 5 comments
Closed

Move template registry to its own repository #82

jackgr opened this issue Nov 16, 2015 · 5 comments
Assignees
Milestone

Comments

@jackgr
Copy link
Contributor

jackgr commented Nov 16, 2015

Currently, the template registry is embedded in this repository. It should be its own repository for several reasons:

  • Make it easier to expose and publicize. As a top level repository, it will be easier to find and access.
  • Establish and maintain the focus of the registry by having no other kind of content in the repository.
  • Make it possible to have different maintainers. People who maintain content contributions should not have to be the same people who maintain code contributions and vice versa.
@jackgr
Copy link
Contributor Author

jackgr commented Nov 16, 2015

Initial thinking:

  • Title is Kubernetes Template Registry
  • Repository name is templates
  • Directory structure is category based (i.e., categories at top level, sub categories below them, etc.)
  • Initial categories include common and storage.
    • replicatedservice lives in common
    • redis lives in storage

@jackgr
Copy link
Contributor Author

jackgr commented Nov 18, 2015

Plans may be changing here, so we should not pull the trigger on this just yet.

@jackgr jackgr modified the milestones: Sprint 10, Sprint 11 Nov 24, 2015
@jackgr jackgr assigned vaikas and unassigned jackgr Nov 24, 2015
@jackgr
Copy link
Contributor Author

jackgr commented Nov 24, 2015

Assigned this to @vaikas-google, since he's already signed up to create the top level repository.

@jackgr jackgr assigned jackgr and unassigned vaikas Nov 24, 2015
@jackgr
Copy link
Contributor Author

jackgr commented Nov 24, 2015

Assigning this task back to me.

@jackgr
Copy link
Contributor Author

jackgr commented Nov 27, 2015

Preparing to implement this issue.

The implementation will follow the process for moving a folder described at Detach subdirectory into separate Git repository and the conventions for organizing a repository described in #25.

Files in the current location (https://github.com/kubernetes/deployment-manager/tree/master/templates) will move to the new location (https://github.com/kubernetes/application-dm-templates) as follows:

  • README.md at the top level of the current location will move to the top level of the new location.
  • The contents of nfs, redis and spark at the top level of the current location will move to a folder named storage in the new location.
  • The contents of replicatedservice in the current location will move to a folder named common in the new location.
  • README.md will be updated to describe the organization of the new repository.
  • The template registry documentation will be updated to capture the decisions recorded in Add support for shortened type names #25.
  • References to the relocated templates in other relocated templates and in kubernetes/deployment-manager/examples will be updated to reflect the change.

/cc @vaikas-google, @bmelville, @zmerlynn

jackgr pushed a commit to jackgr/helm that referenced this issue Nov 29, 2015
jackgr pushed a commit to jackgr/helm that referenced this issue Nov 29, 2015
MichaelMorrisEst pushed a commit to Nordix/helm that referenced this issue Nov 17, 2023
Due to not passing around the pointer into channels and through the functions, we were not getting back the generatedValues. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants