-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--wait-for-jobs does not fails if job failed #9285
--wait-for-jobs does not fails if job failed #9285
Comments
I see,--timeout 10m, when the time is up, what happend in helm? @AcLr |
Yes, install fails. But I expected that fail happens when job failed. Actually |
I already known your mean! @AcLr |
Ok, here is an output. Job already failed and helm still waits:
|
In accordance with the logic of the program, the behave of helm is right.@AcLr |
That's great! Don't you want to change the behave? :) And could you please not to remove your messages? Currently my messages are looked a bit weird) |
My english is poor!
|
I checked #9313 and my problem is not fixed: helm still waits when job failed. And yes I double-checked |
I also checked it and I still have the same problem with waiting failed job :(
And still see waiting for timeout:
|
as mentioned above problem is not closed with #9313 |
Closes helm#9285 Signed-off-by: Rosenberg, Jeff <jeff.rosenberg@icfnext.com>
I've pushed a PR that I hope fixes this -- #9950. It's possible that it's not that simple, I'm open to feedback 🙂 |
@jdolitsky @bacongobbler I'm new to contributing to this project. I have a PR open, but not sure what I need to do to get a review on it, is it okay to just request your review? |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
@jdolitsky @bacongobbler Could you please approve #9950 |
Have the same problem. Waiting for fix |
#9950 fixes this issue for me too :) |
Closes helm#9285 Signed-off-by: Rosenberg, Jeff <jeff.rosenberg@icfnext.com> Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
Output of
helm version
:version.BuildInfo{Version:"v3.5.0", GitCommit:"32c22239423b3b4ba6706d450bd044baffdcf9e6", GitTreeState:"clean", GoVersion:"go1.15.6"}
Output of
kubectl version
:Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"archive", BuildDate:"2020-11-25T13:19:56Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:04:18Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
I have this template:
I installs it with this command:
helm install CHART --wait-for-jobs --wait --timeout 10m
Sometimes job failed (because of tests, yeap :) ), does not restart (because of backoffLimit: 0) and then helm just... waits.
I think that helm should not wait if job failed without any other restarts
The text was updated successfully, but these errors were encountered: