Backfill tests for the tpl function
#11456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<helm#8371> This covers: - `tpl` text can `include` a `define` provided in a partial file - `tpl` text can `include` a `define` provided in its text - `tpl` text can be loaded via `.Files.Get` Signed-off-by: Graham Reed <greed@7deadly.org>
Signed-off-by: Graham Reed <greed@7deadly.org>
Signed-off-by: Graham Reed <greed@7deadly.org>
Signed-off-by: Graham Reed <greed@7deadly.org>
pull-request-size
bot
added
the
size/L
3 tasks
Signed-off-by: Graham Reed <greed@7deadly.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains test-only changes for the
tplfunction to cover all the sharp edges I encountered creating PR http://github.com/helm/helm/pull/11351 and trying to use http://github.com/helm/helm/pull/8371 instead.It verifies current behaviour, especially the aspects affected by those PRs. (Or which I found mattered to our charts before composing http://github.com/helm/helm/pull/11351.)
Special notes for your reviewer:
I have run these tests against both v3.9.4 and v3.10.1 tags as well as the HEAD of main.
Both proposed
tplperformance improvement PRs will fail after this PR is merged. I have a second set of cherries to pick onto http://github.com/helm/helm/pull/11351; I believe the changes are reasonable. (They involve access todefinein the manifest invokingtpland being able to overridedefines from partial files.)However, due to the nature of the
(t) ExecuteTemplate(...)golang function, I now think that http://github.com/helm/helm/pull/8371 cannot be used without effectively turning it into something very similar to http://github.com/helm/helm/pull/11351: it must use(t) Execute(...)instead.If applicable: