Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rollback): helm rollback err tips #12290

Merged
merged 4 commits into from
Aug 25, 2023
Merged

fix(rollback): helm rollback err tips #12290

merged 4 commits into from
Aug 25, 2023

Conversation

Ithrael
Copy link
Contributor

@Ithrael Ithrael commented Aug 10, 2023 •
edited

What this PR does / why we need it:
fix #12288

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@Ithrael Ithrael changed the title fix: helm rollback err tips fix(rollback): helm rollback err tips Aug 10, 2023
@joejulian
Copy link
Contributor

Thanks, that's much better. Could you add tests?

helm/cmd/helm/rollback_test.go

Line 26 in 428c5d5

func TestRollbackCmd(t *testing.T) {

@Ithrael
fix: helm rollback err tips
db9460c 
Signed-off-by: ithrael <wh01096045@gmail.com>
@Ithrael
add rollback unit test
0688046 
Signed-off-by: ithrael <wh01096045@gmail.com>
@Ithrael
add blank
0eb3df6 
Signed-off-by: ithrael <wh01096045@gmail.com>
@Ithrael
remove blank
ee1cbed 
Signed-off-by: ithrael <wh01096045@gmail.com>
@Ithrael
Copy link
Contributor Author

Ithrael commented Aug 19, 2023

Thanks, that's much better. Could you add tests?

helm/cmd/helm/rollback_test.go

Line 26 in 428c5d5

func TestRollbackCmd(t *testing.T) {

I have added unit tests.

joejulian
joejulian approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@joejulian joejulian self-assigned this Aug 24, 2023
@joejulian joejulian added this to the 3.13.0 milestone Aug 25, 2023
@joejulian joejulian merged commit 1d2221f into helm:main Aug 25, 2023
5 checks passed
@Ithrael Ithrael mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejulian joejulian joejulian approved these changes

Assignees

@joejulian joejulian

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

change helm rollback err tips
2 participants
@Ithrael @joejulian