Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): fix GetPodLogs, the hooks should be sorted before get the logs of each hook #12321

Merged
merged 1 commit into from Aug 24, 2023

Conversation

LuBingtan
Copy link
Contributor

@LuBingtan LuBingtan commented Aug 22, 2023

What this PR does / why we need it:
closes #12320
Special notes for your reviewer:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2023
…logs of each hook

Signed-off-by: lubingtan <lubingtan@126.com>
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant. I was having the same problem and have been putting off trying to find a fix. Thank you!

@joejulian joejulian added the bug Categorizes issue or PR as related to a bug. label Aug 23, 2023
@joejulian joejulian added this to the 3.13.0 milestone Aug 23, 2023
@joejulian joejulian self-assigned this Aug 23, 2023
@joejulian joejulian merged commit b6c679e into helm:main Aug 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: helm test --logs fails to show logs when one of multiple tests fails
2 participants