feat(lint): Add new flag --full-path
#12496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
Bhargav-InfraCloud
force-pushed
the
helm_lint_err_full_path
branch
2 times, most recently
from
39f6487
to
d1dd29b
Compare
pull-request-size
bot
added
size/M
|
Excluded tests to bring it down from |
Bhargav-InfraCloud
force-pushed
the
helm_lint_err_full_path
branch
from
d1dd29b
to
260e34d
Compare
The flag --full-path enables printing full paths in linter warnings and errors. Fixes helm#11365 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud
force-pushed
the
helm_lint_err_full_path
branch
from
260e34d
to
1ff3fca
Compare
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/helm
that referenced
this pull request
Apr 4, 2024
Related to helm#12496 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
3 tasks
|
#12923 has the tests related to changes in this. Please review it. It should be merged after this PR's merger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The flag
--full-pathenables printing full paths inhelm lintwarnings and errors.Closes #11365
Special notes for your reviewer:
Excluded tests as the PR becomes
size/XXLwith them. So moved it to #12923 which should be merged on top of this. Please review both.CC: @tillig @joejulian
If applicable: