Update to Go 1.21 for builds #12688
Merged
Update to Go 1.21 for builds #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
mattfarina
force-pushed
the
bump-go-1.21
branch
from
5725da3
to
29d7b34
Compare
pull-request-size
bot
added
size/S
mattfarina
force-pushed
the
bump-go-1.21
branch
2 times, most recently
from
ef13c7a
to
6572c88
Compare
pull-request-size
bot
added
size/M
mattfarina
force-pushed
the
bump-go-1.21
branch
from
6572c88
to
b74457e
Compare
Noteis: 1. This moves golangci scanning to a GitHub action. This will enable inline pointers to issues in the PR where linting fails. 2. Go 1.21 is specified in the go.mod because Kubernetes libs require it. 3. The lint issues were removed. Some were fixed while others were handled by skipping linting or using _ as an argument. Many of these can be refactored later for better cleanup. Signed-off-by: Matt Farina <matt.farina@suse.com>
mattfarina
force-pushed
the
bump-go-1.21
branch
from
b74457e
to
847369c
Compare
pull-request-size
bot
added
size/L
joejulian
approved these changes
Jan 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.21 is required by the Kubernetes packages. So, this change is required.
Some notes:
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: