Add a note about --dry-run displaying secrets #12859
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
sabre1041
reviewed
Mar 10, 2024
cmd/helm/install.go
Outdated
| the '--debug' and '--dry-run' flags can be combined. | ||
| the --debug and --dry-run flags can be combined. | ||
|
|
||
| The --dry-run flag will output all generated chart manifests, including Secrets. |
There was a problem hiding this comment.
Suggested change
| The --dry-run flag will output all generated chart manifests, including Secrets. | |
| The --dry-run flag will output all generated chart manifests, including Secrets, which can contain sensitive values. |
There was a problem hiding this comment.
Because these secrets are chart/template generated they may be plain text. This is before they are sent to Kubernetes.
There was a problem hiding this comment.
Update Updated proposed changes
cmd/helm/install.go
Outdated
| the --debug and --dry-run flags can be combined. | ||
|
|
||
| The --dry-run flag will output all generated chart manifests, including Secrets. | ||
| Please carefully consider the environment it is used in. |
There was a problem hiding this comment.
Suggested change
| Please carefully consider the environment it is used in. | |
| Please carefully consider how and when these arguments are used. |
Signed-off-by: Matt Farina <matt.farina@suse.com>
mattfarina
force-pushed
the
update-dry-run-messaging
branch
from
92182f6
to
a23dd9e
Compare
pull-request-size
bot
added
size/S
|
Note, this documentation is converted into mardown and placed on helm.sh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It adds a message to the install and upgrade help output about
--dry-runand what it outputs. That includes secrets.Special notes for your reviewer: N/A
If applicable: