Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(load.go): add warning on requirements.lock #12867

Merged
merged 1 commit into from
May 15, 2024

Conversation

aauren
Copy link
Contributor

@aauren aauren commented Mar 12, 2024

What this PR does / why we need it:

Adds a warning when requirements.lock is used and the API version is not v1.

Partial fix for: #12853 (full fix to come when this functionality is hopefully removed in v4)

Special notes for your reviewer:

FYI @gjenkins8

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
Signed-off-by: Aaron U'Ren <aauren@users.noreply.github.com>
@aauren
Copy link
Contributor Author

aauren commented Mar 25, 2024

@gjenkins8 Are you still interested in this PR?

Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@mattfarina mattfarina added this to the 3.15.1 milestone May 15, 2024
@mattfarina mattfarina merged commit c16b1c9 into helm:main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants