Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs of DeployedAll #13054

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix docs of DeployedAll #13054

merged 1 commit into from
Jun 11, 2024

Conversation

dastrobu
Copy link
Contributor

What this PR does / why we need it:

Makes the docs conform to the implementation.

Special notes for your reviewer:

--

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2024
@sabre1041
Copy link
Contributor

@dastrobu It appears that there are other instances in that file which need to be updated. Would you be able to update all occurrences that have misalignment between the documentation and the contents within each method?

Please advise if you would like each misalignment to be noted in detail

Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
@dastrobu
Copy link
Contributor Author

@sabre1041 thanks for your feedback. Let's hope I got all places this time (PR updated). Let me know if you find other occurrences that I still overlooked.

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattfarina mattfarina added this to the 3.15.2 milestone Jun 11, 2024
@mattfarina mattfarina merged commit 16c1220 into helm:main Jun 11, 2024
5 checks passed
@mattfarina mattfarina added picked Indicates that a PR has been cherry-picked into the next release candidate. labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
picked Indicates that a PR has been cherry-picked into the next release candidate. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants