New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept .yml files as well as .yaml for templates. #3646
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@nicdoye This is looking good to me! I am just double checking that wasn't added in the first place for a good reason. I should get an answer soon and then I'll merge! |
Accept .yml files as well as .yaml for templates.
@@ -101,7 +101,7 @@ func Templates(linter *support.Linter, values []byte, namespace string, strict b | |||
linter.RunLinterRule(support.ErrorSev, path, validateAllowedExtension(fileName)) | |||
|
|||
// We only apply the following lint rules to yaml files | |||
if filepath.Ext(fileName) != ".yaml" { | |||
if filepath.Ext(fileName) != ".yaml" || filepath.Ext(fileName) == ".yml" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be != ".yml"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. In fact, it should be:
filepath.Ext(fileName) != ".yaml" && filepath.Ext(fileName) != ".yml"
as we only want to go to continue
if it's not .yaml
and it's not .yml
.
See helm/helm-classic#306 for helm classic
and
https://kubernetes.slack.com/archives/C51E88VDG/p1520588964000061
This means charts can be made with
.yml
files. It's backwards compatible ashelm install
doesn't care about the contents of the package, and so older versions ofhelm
can still install the packaged chart.