Fix filenames in tarball created on windows #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
muehlburger
changed the title
pkg/chartutil/save.go
Outdated
| @@ -204,6 +205,7 @@ func writeTarContents(out *tar.Writer, c *chart.Chart, prefix string) error { | |||
| // writeToTar writes a single file to a tar archive. | |||
| func writeToTar(out *tar.Writer, name string, body []byte) error { | |||
| // TODO: Do we need to create dummy parent directory names if none exist? | |||
| name = strings.Replace(name, "\\", "/", -1) | |||
There was a problem hiding this comment.
I think you want to use filepath.ToSlash/filepath.FromSlash here.
There was a problem hiding this comment.
You are right. Thank's for the hint. Updated the PR.
|
I refactored the code. |
bacongobbler
approved these changes
May 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3764.