Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --set-string flag parse booleans and null as strings #4142

merged 3 commits into from Jun 11, 2018


None yet
3 participants
Copy link

elritsch commented May 29, 2018

This makes the --set-string flag behave more intuitively. With this change, the values true, false and null are no longer interpreted as booleans but as strings if --set-string is used.

Closes #2848
Relates to #4006


This comment has been minimized.

Copy link

bacongobbler commented May 29, 2018

cc @arturo-c, any thoughts on this? Seems like a sane design decision to me. If users want to coerce truthy or null values into booleans/nil they can still use --set.

Copy link

bacongobbler left a comment

I'm going to assume silence from @arturo-c means this is fine. Thanks so much @elritsch for the patch! Really appreciate adding the --set tests you added here as well. 👍

@bacongobbler bacongobbler merged commit daeb458 into helm:master Jun 11, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
cla/linuxfoundation elritsch authorized

@elritsch elritsch deleted the elritsch:set-string-force-string-value-for-booleans-and-null branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.