Make --set-string flag parse booleans and null as strings #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
cc @arturo-c, any thoughts on this? Seems like a sane design decision to me. If users want to coerce truthy or null values into booleans/nil they can still use |
bacongobbler
approved these changes
Jun 11, 2018
There was a problem hiding this comment.
I'm going to assume silence from @arturo-c means this is fine. Thanks so much @elritsch for the patch! Really appreciate adding the --set tests you added here as well. 👍
ScriptingSquirrel
deleted the
set-string-force-string-value-for-booleans-and-null
branch
bacongobbler
pushed a commit
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
--set-stringflag behave more intuitively. With this change, the valuestrue,falseandnullare no longer interpreted as booleans but as strings if--set-stringis used.Closes #2848
Relates to #4006