Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release_server): handle the case when requested values is empty #4604

Merged
merged 1 commit into from Sep 7, 2018
Merged

fix(release_server): handle the case when requested values is empty #4604

merged 1 commit into from Sep 7, 2018

Conversation

bacongobbler
Copy link
Member

@bacongobbler bacongobbler commented Sep 6, 2018 •
edited

closes #4337 for real this time!

cc @michelleN

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

fix(release_server): handle the case when requested values is empty
f31a074 
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@bacongobbler bacongobbler added this to the 2.11.0 - Features milestone Sep 6, 2018
@bacongobbler bacongobbler added awaiting review bug Categorizes issue or PR as related to a bug. labels Sep 6, 2018
@bacongobbler bacongobbler changed the title fix(release_server): fix how we merge values, take 2 fix(release_server): handle the case when requested values is empty Sep 6, 2018
@timgclark
Copy link

timgclark commented Sep 7, 2018 •
edited

Built, tested, and confirmed working:

Client: &version.Version{SemVer:"v2.10+unreleased", GitCommit:"f31a074e89588fc21597fc557abe420942975a55", GitTreeState:"dirty"}
Server: &version.Version{SemVer:"v2.10+unreleased", GitCommit:"f31a074e89588fc21597fc557abe420942975a55", GitTreeState:"dirty"}
root@ubuntuguest:~/go/src/k8s.io/helm# helm upgrade percona ./percona-0.5.2.tgz --reuse-values 2>/dev/null|head
LAST DEPLOYED: Fri Sep  7 14:49:31 2018
NAMESPACE: default
STATUS: DEPLOYED
...


Thanks for the quick turnaround.

thomastaylor312
thomastaylor312 approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked that this worked. LGTM.

@bacongobbler bacongobbler merged commit 941b1f4 into helm:master Sep 7, 2018
@bacongobbler bacongobbler deleted the fix-4337 branch September 7, 2018 19:22
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
@splisson
fix(release_server): handle the case when requested values is empty (h…
98e3ad4 
…elm#4604)

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
@splisson
fix(release_server): handle the case when requested values is empty (h…
95cb34c 
…elm#4604)

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
@splisson
fix(release_server): handle the case when requested values is empty (h…
4648afc 
…elm#4604)

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
@splisson
fix(release_server): handle the case when requested values is empty (h…
9be3b81 
…elm#4604)

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.11.0 - Features
Development

Successfully merging this pull request may close these issues.

Helm upgrade with reuse-values, without --set gives YAML error
3 participants
@bacongobbler @timgclark @thomastaylor312