New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SIGSEGV when storage driver returns nil error (#3625) #4627
Conversation
A note on testing ... this is a hard one to test for; the only existing test that might trigger this is helm/pkg/tiller/release_server_test.go Line 357 in b4b693c
moniker chose the name happy-panda ; with the current version of moniker having 243 animals and 390 descriptors, that's a 1 in 94,770 chance (0.001%) of triggering the bug during testing.
I could update this PR with a bigger rewrite that allows the use of something that satisfies the |
6c3cc4e
to
1472ffa
Compare
PR updated to add a test which, based on the original code causes a segfault and confirms that the fix is valid |
99d58ba
to
b074784
Compare
hey! looks like the commit history is mangled. Mind taking a look into fixing that? |
Yeah, whoops ... sorry. Fixing that now |
ef1c3ae
to
3750ec9
Compare
helm#3625) Signed-off-by: Colin Panisset <colin.panisset@cevo.com.au>
3750ec9
to
8ccfa05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This addresses #3625 where
tiller
segfaults inuniqName
-- the check for an existing name assumes that the storage driver'sGet
function always returns a validerror
type, but for example thecfgmaps
driver (default) often returns anil