New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appveyor): fix up failing unit tests on Windows #4897
Conversation
woop! We have legitimate Windows test failures. 🎉 |
I think it has to do with how
This boils down to |
okay. I've skipped that particular test because there is no equivalent to |
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com
closes #2456
closes #3690