Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appveyor): fix up failing unit tests on Windows #4897

Merged
merged 1 commit into from Nov 28, 2018
Merged

fix(appveyor): fix up failing unit tests on Windows #4897

merged 1 commit into from Nov 28, 2018

Conversation

bacongobbler
Copy link
Member

@bacongobbler bacongobbler commented Nov 8, 2018

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

closes #2456
closes #3690

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2018
@bacongobbler
Copy link
Member Author

woop! We have legitimate Windows test failures. 🎉

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2018
@bacongobbler bacongobbler changed the title fix(appveyor): install glide, not dep fix(appveyor): fix up failing unit tests on Windows Nov 15, 2018
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2018
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2018
@radu-matei
Copy link
Contributor

I think it has to do with how git is configured on the Windows box (specifically the behaviour of Git Bash when using PowerShell), but:

  • when using PowerShell:
 $ go.exe test k8s.io\helm\pkg\getter -run ^TestPluginGetter$
--- FAIL: TestPluginGetter (0.03s)
    plugingetter_test.go:83: exec: "echo": executable file not found in %PATH%
FAIL
FAIL    k8s.io/helm/pkg/getter  0.093s
  • when using Git Bash:
$ go.exe test k8s.io/helm/pkg/getter -run ^TestPluginGetter$
ok      k8s.io/helm/pkg/getter  0.160s

This boils down to echo being a command under Windows, and not an executable, as for UNIX systems. So while the AppVeyor tests might be passing (since most likely they run under Git Bash), under regular PowerShell TestPluginGetter fails.

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2018
@bacongobbler
Copy link
Member Author

bacongobbler commented Nov 27, 2018

okay. I've skipped that particular test because there is no equivalent to echo on Windows, as it's a builtin command for cmd.exe and therefore not an executable.

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2018
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2018
Copy link
Contributor

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacongobbler bacongobbler merged commit 97465ab into helm:master Nov 28, 2018
@bacongobbler bacongobbler deleted the fix-appveyor branch November 28, 2018 17:59
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
consolewitch pushed a commit to consolewitch/helm that referenced this pull request Jan 7, 2019
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
eraac pushed a commit to eraac/helm that referenced this pull request Mar 21, 2019
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm repo index with subfolders creates urls with backslashes [META] Works on Windows, yet?
5 participants