Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing helm search display format #5148 #5162

Merged
merged 1 commit into from Jan 17, 2019
Merged

Fixing helm search display format #5148 #5162

merged 1 commit into from Jan 17, 2019

Conversation

thesattiraju
Copy link

What this PR does / why we need it:
closes #5148

Special notes for your reviewer:

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2019
@thesattiraju
Fixing helm search display format helm#5148
9497123 
Signed-off-by: ds-ms <desattir@microsoft.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@thesattiraju
Copy link
Author

@bacongobbler could you review?

SlickNik
SlickNik approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@SlickNik SlickNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks @DS-MS

@bacongobbler bacongobbler merged commit a4bc9fd into helm:master Jan 17, 2019
@thesattiraju thesattiraju deleted the warnNewLine branch January 18, 2019 05:56
eraac pushed a commit to eraac/helm that referenced this pull request Mar 21, 2019
@thesattiraju
Fixing helm search display format helm#5148 (helm#5162)
feee71d 
Signed-off-by: ds-ms <desattir@microsoft.com>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlickNik SlickNik SlickNik approved these changes

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm search display wrong format if some repos unreachable
4 participants
@thesattiraju @SlickNik @bacongobbler @helm-bot