feat(helm): adding --name to update single repo #5182

thesattiraju · 2019-01-17T13:49:34Z

What this PR does / why we need it:
fixes #5127

Special notes for your reviewer:

If applicable:

this PR contains documentation
this PR contains unit tests
this PR has been tested for backwards compatibility

thesattiraju · 2019-01-28T11:18:05Z

@bacongobbler / @adamreese could you review this?

adamreese · 2019-01-31T21:54:55Z

Rather than adding a --name flag, could we just use arguments?

Example: helm repo update stable

thesattiraju · 2019-02-03T12:55:43Z

@adamreese I agree that removing --name makes it better.
We'll end up having one new path though right? i.e. helm repo update and helm repo update <repo_name>.
I was skeptical about how to convey that helm repo update meant helm would update all repos, so I chose this path instead.

thesattiraju · 2019-02-04T09:32:26Z

@adamreese I've updated it to helm repo update <repo_name> instead.

thesattiraju · 2019-03-18T17:16:15Z

@adamreese @bacongobbler ping

thesattiraju · 2019-05-28T06:39:11Z

@adamreese @bacongobbler pinging again

hickeyma

@DS-MS Thanks for the changes. It is nearly there but it needs some updates as follows:

Do you mind updating the command use to include "[repo_name]" (https://github.com/helm/helm/blob/master/cmd/helm/repo_update.go#L56)
Do you mind adding unit test to https://github.com/helm/helm/blob/master/cmd/helm/repo_update_test.go

thesattiraju · 2019-05-31T05:20:01Z

@hickeyma Updated the PR

hickeyma

Thanks @DS-MS for the updates. I would appreciate if you could add a positive test as described in the inline comment.

hickeyma · 2019-06-04T14:37:57Z

cmd/helm/repo_update_test.go

@@ -132,3 +132,29 @@ func TestUpdateCmdStrictFlag(t *testing.T) {
 		t.Errorf("Expected 'Unable to get an update', got %q", got)
 	}
 }
+


Do you mind adding a test that tests for a successful update with a single repo name?

@hickeyma added.

hickeyma

Thanks for adding the positive test. Some nits on it. When you deliver changes, can you also squash the changes on this PR?

cmd/helm/repo_update_test.go

thesattiraju · 2019-06-07T09:50:54Z

@hickeyma updated

hickeyma

Nearly there. Just small nit on caps on repo name for consistency.

hickeyma · 2019-06-07T11:14:10Z

cmd/helm/repo_update.go

@@ -53,12 +62,15 @@ func newRepoUpdateCmd(out io.Writer) *cobra.Command {
 		update: updateCharts,
 	}
 	cmd := &cobra.Command{
-		Use:     "update",
+		Use:     "update [repo_name]",


:s/repo_name/REPO_NAME
for consistency with commands like helm get, helm install etc.

Signed-off-by: Deepak Sattiraju <desattir@microsoft.com> Lint Signed-off-by: ds-ms <desattir@microsoft.com> make docs Signed-off-by: ds-ms <desattir@microsoft.com> make docs Signed-off-by: ds-ms <desattir@microsoft.com> Signed-off-by: Deepak Sattiraju <desattir@microsoft.com> using args instead of --name Signed-off-by: ds-ms <desattir@microsoft.com> Adding [repo_name] to use Signed-off-by: ds-ms <desattir@microsoft.com> Adding test Signed-off-by: ds-ms <desattir@microsoft.com> Adding positive test case Signed-off-by: ds-ms <desattir@microsoft.com> lint Signed-off-by: ds-ms <desattir@microsoft.com> Renaming Signed-off-by: ds-ms <desattir@microsoft.com> Updating repo_name to REPO_NAME feat(helm): adding --name to update single repo Signed-off-by: Deepak Sattiraju <desattir@microsoft.com> Lint Signed-off-by: ds-ms <desattir@microsoft.com> make docs Signed-off-by: ds-ms <desattir@microsoft.com> make docs Signed-off-by: ds-ms <desattir@microsoft.com> Signed-off-by: Deepak Sattiraju <desattir@microsoft.com> using args instead of --name Signed-off-by: ds-ms <desattir@microsoft.com> Adding [repo_name] to use Signed-off-by: ds-ms <desattir@microsoft.com> Adding test Signed-off-by: ds-ms <desattir@microsoft.com> Adding positive test case Signed-off-by: ds-ms <desattir@microsoft.com> lint Signed-off-by: ds-ms <desattir@microsoft.com> Renaming Signed-off-by: ds-ms <desattir@microsoft.com> Updating repo_name to REPO_NAME

hickeyma

LGTM, thanks.

This is a port to helm v3 of helm#5182. A little more flexible than the v2 version, it allows to specify a list of repositories that should be updated. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>

This is a port to helm v3 of #5182. A little more flexible than the v2 version, it allows to specify a list of repositories that should be updated. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>

This is a port to helm v3 of helm#5182. A little more flexible than the v2 version, it allows to specify a list of repositories that should be updated. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>

helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2019

thesattiraju force-pushed the RepoUpdateName branch from fd583bc to 8ddec21 Compare January 17, 2019 13:50

helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2019

thesattiraju force-pushed the RepoUpdateName branch from 68d4b9d to 31d2e3a Compare January 17, 2019 16:21

helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2019

thesattiraju force-pushed the RepoUpdateName branch from 8953004 to 4b10510 Compare January 24, 2019 06:02

helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2019

helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2019

hickeyma requested changes May 28, 2019

View reviewed changes

hickeyma requested changes Jun 4, 2019

View reviewed changes

helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2019

thesattiraju force-pushed the RepoUpdateName branch from 2601f0c to 5bea51a Compare June 7, 2019 07:18

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 7, 2019

hickeyma requested changes Jun 7, 2019

View reviewed changes

thesattiraju force-pushed the RepoUpdateName branch 2 times, most recently from 0a94c1c to 15d5854 Compare June 7, 2019 09:49

hickeyma added the feature label Jun 7, 2019

hickeyma requested changes Jun 7, 2019

View reviewed changes

thesattiraju force-pushed the RepoUpdateName branch from 15d5854 to b0b282f Compare June 7, 2019 11:18

thesattiraju force-pushed the RepoUpdateName branch from b0b282f to c49ba7d Compare June 7, 2019 11:28

hickeyma approved these changes Jun 7, 2019

View reviewed changes

hickeyma merged commit 5133af0 into helm:master Jun 7, 2019

thesattiraju deleted the RepoUpdateName branch June 7, 2019 12:03

marckhouzam added the Needs v3 fix label Jun 22, 2021

marckhouzam mentioned this pull request Jun 22, 2021

feat(cmd): Allow to specify which repos to update #9845

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(helm): adding --name to update single repo #5182

feat(helm): adding --name to update single repo #5182

thesattiraju commented Jan 17, 2019 •

edited

thesattiraju commented Jan 28, 2019

adamreese commented Jan 31, 2019

thesattiraju commented Feb 3, 2019

thesattiraju commented Feb 4, 2019

thesattiraju commented Mar 18, 2019

thesattiraju commented May 28, 2019

hickeyma left a comment

thesattiraju commented May 31, 2019

hickeyma left a comment

hickeyma Jun 4, 2019

thesattiraju Jun 7, 2019

hickeyma left a comment

thesattiraju commented Jun 7, 2019

hickeyma left a comment

hickeyma Jun 7, 2019

thesattiraju Jun 7, 2019

hickeyma left a comment

feat(helm): adding --name to update single repo #5182

feat(helm): adding --name to update single repo #5182

Conversation

thesattiraju commented Jan 17, 2019 • edited

thesattiraju commented Jan 28, 2019

adamreese commented Jan 31, 2019

thesattiraju commented Feb 3, 2019

thesattiraju commented Feb 4, 2019

thesattiraju commented Mar 18, 2019

thesattiraju commented May 28, 2019

hickeyma left a comment

Choose a reason for hiding this comment

thesattiraju commented May 31, 2019

hickeyma left a comment

Choose a reason for hiding this comment

hickeyma Jun 4, 2019

Choose a reason for hiding this comment

thesattiraju Jun 7, 2019

Choose a reason for hiding this comment

hickeyma left a comment

Choose a reason for hiding this comment

thesattiraju commented Jun 7, 2019

hickeyma left a comment

Choose a reason for hiding this comment

hickeyma Jun 7, 2019

Choose a reason for hiding this comment

thesattiraju Jun 7, 2019

Choose a reason for hiding this comment

hickeyma left a comment

Choose a reason for hiding this comment

thesattiraju commented Jan 17, 2019 •

edited