Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm repo subcommands aliases #6589

Merged
merged 2 commits into from Oct 7, 2019
Merged

helm repo subcommands aliases #6589

merged 2 commits into from Oct 7, 2019

Conversation

Efrat19
Copy link
Contributor

@Efrat19 Efrat19 commented Oct 7, 2019

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2019
@Efrat19
helm repo subcommands aliases
781c97b 
Signed-off-by: Efrat19 <efrat890089@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2019
@Efrat19
lint
a6acb53 
Signed-off-by: Efrat19 <efrat890089@gmail.com>
@Efrat19 Efrat19 mentioned this pull request Oct 7, 2019
Merged
3 tasks
@rimusz
Copy link
Contributor

rimusz commented Oct 7, 2019

@Efrat19 than you for your PR those aliases are handy to have 👍

@Efrat19
Copy link
Contributor Author

Efrat19 commented Oct 7, 2019

@Efrat19 than you for your PR those aliases are handy to have 👍

this goes up...
https://twitter.com/EfratLevitan/status/1181119128612069376?s=20

hickeyma
hickeyma approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Efrat19 for adding these aliases.

@hickeyma hickeyma added feature v3.x Issues and Pull Requests related to the major version v3 labels Oct 7, 2019
@hickeyma hickeyma merged commit 98a33fb into helm:dev-v3 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hickeyma hickeyma hickeyma approved these changes

Assignees
No one assigned
Labels
feature size/S Denotes a PR that changes 10-29 lines, ignoring generated files. v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Efrat19 @rimusz @hickeyma @helm-bot