Allow namespace to be set by programs consuming helm. #6798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Mell <amell@lumindigital.com>
helm-bot
added
the
size/M
bacongobbler
approved these changes
Oct 27, 2019
|
Would you mind writing a unit test to cover this? |
|
@bacongobbler Sure, were you thinking a test to verify that the namespace is correct? or something else? |
thomastaylor312
added
breaking
feature
v3.x
|
Labeled as breaking because it is changing a publicly exported function signature |
bc2cd3c Signed-off-by: Aaron Mell <amell@lumindigital.com>
helm-bot
added
size/S
|
@bacongobbler @thomastaylor312 I reworked my change to reduce the scope, I think its a better way to fix it than changing the Namespace scope. |
thomastaylor312
suggested changes
Oct 28, 2019
Signed-off-by: Aaron Mell <amell@lumindigital.com>
thomastaylor312
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
I'll let @bacongobbler give this one more look because he started review
bacongobbler
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Mell amell@lumindigital.com
When consuming the helm client, there is no way to correctly set the namespace except via an env variable, and that doesn't work with terraform possibly running the client concurrently in multiple namespaces.
I'm not sure if you want to expose Namespace. If thats the case, maybe a SetNamespace function?