fix: backport #6361 fix to Helm 2 #7196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
helm-bot
added
the
size/XS
technosophos
added
awaiting review
bug
|
I would like to propose adding this to 2.16.2 if we can. |
jdolitsky
approved these changes
Dec 10, 2019
|
hey, sorry to dig here... is there an ETA for this to be released? |
|
We do not have a release planned for 2.x for the remainder of the year. 3.0.2, which shipped today, has a version of this fix. So for 2.x, we are probably looking at January 2020 |
|
I saw the 3.0.2 is already released. Hope 2.16.2 release soon |
|
Could we please have 2.16.4 released? This issue happens on GKE every other time. Very annoying. |
hickeyma
added
needs-pick
mattfarina
added
the
picked
mattfarina
pushed a commit
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com> (cherry picked from commit ab79732)
|
Question: Since this was labeled as "picked" on 2020-03-23, shouldn't it be present on Helm 2.16.5 released on 2020-03-26?
UPDATE: Nevermind. I see that this change was cherry picked and included in the message: |
|
Backports #6908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a similar fix to the one(s) that handle #6361 for Helm 3. This won't necessarily fix Rudder, but it will fix Tiller.
Signed-off-by: Matt Butcher matt.butcher@microsoft.com