feat(template): Allow template output to use release name #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
hickeyma
added
feature
v3.x
thomastaylor312
approved these changes
Feb 3, 2020
helm template output command uses the chart name only when writing templates to disk. This changes will also use the release name to avoid colloiding the path when output nore than one release of smae chart. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
hickeyma
force-pushed
the
feat/template-out-with-relname
branch
from
eedc382
to
0cc66f2
Compare
Comment: - https://github.com/helm/helm/pull/7503/files#r374130090 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
|
Thanks for review @thomastaylor312 |
hickeyma
added
the
needs-pick
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
* Allow template output to use release name helm template output command uses the chart name only when writing templates to disk. This changes will also use the release name to avoid colloiding the path when output nore than one release of smae chart. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> * Update after review Comment: - https://github.com/helm/helm/pull/7503/files#r374130090 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
* Allow template output to use release name helm template output command uses the chart name only when writing templates to disk. This changes will also use the release name to avoid colloiding the path when output nore than one release of smae chart. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> * Update after review Comment: - https://github.com/helm/helm/pull/7503/files#r374130090 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
* Allow template output to use release name helm template output command uses the chart name only when writing templates to disk. This changes will also use the release name to avoid colloiding the path when output nore than one release of smae chart. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> * Update after review Comment: - https://github.com/helm/helm/pull/7503/files#r374130090 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
marckhouzam
removed
the
needs-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm template --output-dircommand uses the chart name only when writing templates to disk. This causes collision in the path when running the command for different releases of the same chart. This feature allows the release name to be used to avoid second invocation clobbering the previous output.New path format:
outputDir/<releaseName>/<chart>/templatesCloses #5664