ref(tests): localize unit test fixtures to package #8189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use test fixtures that are in the same package as test. Signed-off-by: Adam Reese <adam@reese.io>
helm-bot
added
the
size/XXL
technosophos
approved these changes
May 22, 2020
There was a problem hiding this comment.
LGTM.
This is exclusively a re-organization of tests. The one non-test API that changed is changed in a non-breaking way to expose a private variable to the testing fixtures. Many unnecessary files are remoed. And the more disk IO we can ditch during testing, the better our tests will perform.
| output, err := client.Run("../../cmd/helm/testdata/testcharts/alpine") | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| client.chart = &chart.Chart{ |
There was a problem hiding this comment.
Ah! Yes! This is much cleaner for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use test fixtures that are in the same package as test.