feat(helm): prompt for password with helm repo add #8431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in Helm 2, 'helm repo add' would prompt for your password if you only provided the --username flag. This helps prevent someone's credentials from being logged in their shell's history, from showing up in process lists, and from being seen by others nearby. Closes helm#7174 Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
helm-bot
added
the
size/S
bacongobbler
requested changes
Jul 10, 2020
Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
Yes, I have tested locally using a private repository. My |
bacongobbler
approved these changes
Jul 10, 2020
jrweldon
added a commit
to jrweldon/helm
that referenced
this pull request
Jul 11, 2020
Fix broken windows/amd64 build caused by helm#8431 https://golang.org/pkg/syscall/#pkg-variables indicated that `syscall.Stdin` should have been an `int`, though it's actually a `syscall.Handle` on Windows, which is a `uintptr`. In a similar issue posted to golang, a member of the Golang team stated that the fix would be to cast it to an int. Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
jrweldon
added a commit
to jrweldon/helm
that referenced
this pull request
Jul 11, 2020
No longer using the 'syscall' package, as further reading into this issue has shown that 'syscall' is deprecated/locked down. Additional issues posted on Golang's github indicates that the newer preferred mechanism to get the file descriptor for stdin is: int(os.Stdin.Fd()) Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
bacongobbler
pushed a commit
that referenced
this pull request
Jul 11, 2020
fix windows build failure caused by #8431
ashokponkumar
pushed a commit
to ashokponkumar/helm
that referenced
this pull request
Jul 14, 2020
No longer using the 'syscall' package, as further reading into this issue has shown that 'syscall' is deprecated/locked down. Additional issues posted on Golang's github indicates that the newer preferred mechanism to get the file descriptor for stdin is: int(os.Stdin.Fd()) Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com> Signed-off-by: Ashok Pon Kumar <ashokponkumar@in.ibm.com>
ashokponkumar
pushed a commit
to ashokponkumar/helm
that referenced
this pull request
Jul 14, 2020
No longer using the 'syscall' package, as further reading into this issue has shown that 'syscall' is deprecated/locked down. Additional issues posted on Golang's github indicates that the newer preferred mechanism to get the file descriptor for stdin is: int(os.Stdin.Fd()) Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com> Signed-off-by: Ashok Pon Kumar <ashokponkumar@in.ibm.com>
|
Did this feature not make it into Helm 3.3.0? |
|
No, it was a few days after the 3.3 cutoff, it'll be in 3.4 |
vladfr
pushed a commit
to vladfr/helm
that referenced
this pull request
Sep 30, 2020
No longer using the 'syscall' package, as further reading into this issue has shown that 'syscall' is deprecated/locked down. Additional issues posted on Golang's github indicates that the newer preferred mechanism to get the file descriptor for stdin is: int(os.Stdin.Fd()) Signed-off-by: Jack Weldon <jack.weldon.scm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Closes #7174
Previously in Helm 2,
helm repo addwould prompt for your password if you only provided the--usernameflag. This helps prevent someone's credentials from being logged in their shell's history, from showing up in process lists, and from being seen by others nearby.Special notes for your reviewer:
This is my first time contributing to a large open-source project, please let me know if anything else is needed or desired and I'll do my best to address the concerns as soon as possible.
If applicable: