fix(kube): use logger instead of fmt.Printf #8437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
Signed-off-by: Hidde Beydals <hello@hidde.co>
|
This will help us with fluxcd/helm-controller#11 |
|
👍 Nice catch! |
hickeyma
approved these changes
Jul 13, 2020
hickeyma
added
needs-pick
marckhouzam
removed
the
needs-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed to be the only place where
fmt.Printfwas used instead ofLogorfmt.Fprintf(out, ...). GivenLogis available within the client, accepting this PR would give consumers better control over how things are printed during test runs.