Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cache index file to load Chart Repository #8724

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use cache index file to load Chart Repository #8724

wants to merge 3 commits into from

Conversation

object88
Copy link
Contributor

Signed-off-by: Paul Brousseau object88@gmail.com

closes #8044

What this PR does / why we need it:

Changes the behavior of the repo.ChartRepository.Load func to use the r.CachePath if the r.Config.Name does not match a file.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@object88
Use cache index file to load Chart Repository
95347ba 
Signed-off-by: Paul Brousseau <object88@gmail.com>
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2020
@bacongobbler
Copy link
Member

Hi @object88. Looks like the tests are failing here. Would you mind looking into that? Thanks.

@object88
Copy link
Contributor Author

Absolutely! Buuuuut, I am unsure where to go from here. I ran both make test and make test-coverage locally (Go 1.15.2 darwin/amd64), and tests are passing. I don't have the ability; can you rerun the CircleCI tests? Alternately, is there another way to run the tests that better approximates the CircleCI tests locally?

@object88
Copy link
Contributor Author

Ohh, I see why the tests aren't passing. CircleCI is putting a _cover_.out file into the temp directory, and my test is erasing the contents of that directory. Will fix.

@object88
use ensure.TempDir instead of os.TempDir to get unique directory
0bde2d2 
Signed-off-by: Paul Brousseau <object88@gmail.com>
@object88
Copy link
Contributor Author

Apologies for the force push; forgot to sign a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repo.ChartRepository.Load has presumption about current working directory
4 participants
@object88 @bacongobbler @hickeyma @helm-bot