Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix formatting error #8758

Merged
merged 1 commit into from Sep 17, 2020
Merged

fix formatting error #8758

merged 1 commit into from Sep 17, 2020

Conversation

technosophos
Copy link
Member

Signed-off-by: Matt Butcher matt.butcher@microsoft.com

What this PR does / why we need it:

Fix an issue that new Go toolchains cannot convert an int to a string.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@technosophos
fix formatting error
dda4d7a 
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
@technosophos technosophos added this to the 2.16.11 milestone Sep 17, 2020
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2020
@technosophos technosophos merged commit b9566b8 into helm:dev-v2 Sep 17, 2020
@technosophos technosophos deleted the fix/go-toolchain-fix branch September 17, 2020 19:46
@technosophos technosophos added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Sep 17, 2020
technosophos added a commit that referenced this pull request Sep 17, 2020
@technosophos
fix formatting error (#8758)
73b28ba 
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
@bacongobbler bacongobbler added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacongobbler bacongobbler bacongobbler approved these changes

@adamreese adamreese adamreese approved these changes

Assignees
No one assigned
Labels
needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
2.16.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@technosophos @bacongobbler @adamreese @helm-bot