change behavior when add repo with same name and url. #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yxxhero <aiopsclub@163.com>
helm-bot
added
the
size/L
This was referenced Sep 21, 2020
bacongobbler
requested changes
Sep 21, 2020
There was a problem hiding this comment.
Thank you for the quick PR. However while reviewing, I do not believe there is need for some of the function calls added here. These newly introduced function calls are overly verbose and are leaky in design.
I will submit an alternative PR to fix this issue. Thank you for your effort.
| @@ -85,6 +85,22 @@ func (r *File) Has(name string) bool { | |||
| return entry != nil | |||
| } | |||
|
|
|||
| // HasRepoWithNameAndURL returns true if the given name whth url is already a repository name. | |||
| func (r *File) HasRepoWithNameAndURL(name string, url string) bool { | |||
There was a problem hiding this comment.
Why are we introducing these functions?
| } | ||
|
|
||
| // GetRepoByNameAndURL returns an entry with the given name and url if it exists, otherwise returns nil | ||
| func (r *File) GetRepoByNameAndURL(name string, url string) *Entry { |
|
See #8777. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yxxhero aiopsclub@163.com
What this PR does / why we need it:
resolve: #8771
We could just return exit code zero if the same repo is attempted to be added twice with the same name.
Special notes for your reviewer:
If applicable: