Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm create: make generated YAML indentation more consistent #8874

Merged

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Oct 12, 2020

What this PR does / why we need it:
It just makes the indentation of generated output of helm create indented more consistently.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2020
Signed-off-by: Erik Sundell <erik@sundellopensource.se>
@consideRatio consideRatio force-pushed the pr/helm-create-template-indentation branch from d540fb3 to 1d9767f Compare October 12, 2020 13:45
Copy link
Member

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs another maintainer to approve before merging.

Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @consideRatio

@hickeyma hickeyma merged commit 8667aa4 into helm:master Oct 13, 2020
@hickeyma hickeyma added this to the 3.4.0 milestone Oct 13, 2020
@hickeyma hickeyma added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Oct 13, 2020
@bacongobbler
Copy link
Member

As a note, commits do not need to be cherry-picked into a minor release. As per the release checklist, the next minor release is cut from the HEAD of the master branch. Cherry picks are only necessary for patch releases.

https://helm.sh/docs/community/release_checklist/#1-create-the-release-branch

Removing the needs-pick label accordingly. :)

@bacongobbler bacongobbler removed the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants