Moving Tiller to new location #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/L
bacongobbler
requested changes
Oct 13, 2020
scottrigby
reviewed
Oct 14, 2020
There was a problem hiding this comment.
otherwise this lgtm 👍
I was going to suggest perhaps a GitHub action could simplify auth now that we're omving to ghcr, but I see the GITHUB_TOKEN doesn't have the right perms for that yet during the beta. Plus we want to auth for the other registries anyway. So could be a follow-up if we want to do that.
.circleci/deploy.sh
Outdated
| az storage blob upload -f "KEYS" -n "KEYS" -c "$AZURE_STORAGE_CONTAINER_NAME" --connection-string "$AZURE_STORAGE_CONNECTION_STRING" | ||
| echo "Pushing KEYS file to Azure" | ||
| az storage blob upload -f "KEYS" -n "KEYS" -c "$AZURE_STORAGE_CONTAINER_NAME" --connection-string "$AZURE_STORAGE_CONNECTION_STRING" | ||
| endif |
There was a problem hiding this comment.
shellify. also adding newline at EOF
Suggested change
| endif | |
| fi | |
.circleci/deploy.sh
Outdated
|
|
||
| # Canary version is used with helm init --canary-image flag. | ||
| # Does not push canary binary which is Helm v3. | ||
| ifneq ($(VERSION),"canary") |
There was a problem hiding this comment.
looks like some make crept in. shellify-ing:
Suggested change
| ifneq ($(VERSION),"canary") | |
| if [ "$VERSION" != "canary" ]; then |
There was a problem hiding this comment.
Good catch. fixed. thanks.
mattfarina
force-pushed
the
new-image-location
branch
from
3867d50
to
c63eb1e
Compare
The tiller primary location is now GitHub Container Registry. It is also replicatated to GCR, Docker Hub, and Quay. Signed-off-by: Matt Farina <matt@mattfarina.com>
mattfarina
force-pushed
the
new-image-location
branch
from
c63eb1e
to
01dc62e
Compare
scottrigby
approved these changes
Oct 14, 2020
bacongobbler
approved these changes
Oct 14, 2020
This was referenced Oct 14, 2020
udaraau
pushed a commit
to OpenLimark/java8-eks-helm-client
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tiller primary location is now GitHub Container Registry.
It is also replicatated to GCR, Docker Hub, and Quay.
What this PR does / why we need it:
GCR is going away. We want to preserve tiller beyond the end of life for Helm v2. This moves Tiller to GHCR along with making it available on Quay and Docker Hub.
Special notes for your reviewer:
The environment variables are already setup in CI.
If applicable: