New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add ability for --dry-run to do lookup functions #9426
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
92a6640
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia 51281c1
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia 4d67dfa
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia fc16ea7
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia be99ebe
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia ddb3358
feat(helm): add ability for a dry-run to evaluate lookup functions
tapaskapadia d66c7db
feat(helm): add ability for a dry-run to evaluate lookup functions
tapaskapadia 5ec7913
feat(helm): add ability for a dry-run to evaluate lookup functions
tapaskapadia 9a0025f
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia 25ac62e
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia f9e54b6
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia 4899e8a
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia 4b7248e
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia b7a2d47
feat(helm): add ability for --dry-run to do lookup functions
tapaskapadia File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output in the generated help documentation reads...
It includes a
="client"
and the default value beingunchanged
. To an end user trying to read this it may be confusing.What if the default value was
""
instead of"unchanged"
? In install, upgrade, and template Helm could check for an empty string to make it's changes. Then the default ofunchanged
would not be presented to the end user?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call out. I'll change it to
""
so end users are not exposed to this internal default value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tapaskapadia I think this is my one nit I would like to see changed before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfarina I just pushed up the changes to make the default value "" which does make the help documentation much clearer. Here's how the help documentation reads now:
Here's the expected behavior table (nothing has changed) with my matching test results including the latest changes: test_04-30-23.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any further action needed here? I'm happy to help in any way possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattfarina @tapaskapadia Are there any additional changes required before this can be merged? It seems like all of the requested changes have been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philomory I believe I have implemented all the requested changes. If there’s anything else needed, I am happy to make changes.