Add consistent-type-imports rule

See <https://typescript-eslint.io/rules/consistent-type-imports/>.

This is useful for consistency but also to avoid side-effects for
type-only imports.

.eslintrc.json

@@ -15,6 +15,7 @@
   "rules": {
     "no-unused-vars": "off",
     "@typescript-eslint/consistent-type-exports": "error",
+    "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-confusing-void-expression": "error",
     "@typescript-eslint/no-duplicate-enum-values": "error",
     "@typescript-eslint/no-duplicate-type-constituents": "error",

build/build-package.ts

@@ -5,7 +5,7 @@ import * as zlib from "zlib";
 import { fileURLToPath } from "url";
 import { pipeline } from "stream";
 import { promisify } from "util";
-import { RollupBuild, rollup } from "rollup";
+import { rollup, type RollupBuild } from "rollup";
 import rollupTypescript from "@rollup/plugin-typescript";
 import rollupDts from "rollup-plugin-dts";
 import prettier from "prettier";

index.ts

@@ -1,33 +1,33 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 import contentSecurityPolicy, {
-  ContentSecurityPolicyOptions,
+  type ContentSecurityPolicyOptions,
 } from "./middlewares/content-security-policy/index.js";
 import crossOriginEmbedderPolicy, {
-  CrossOriginEmbedderPolicyOptions,
+  type CrossOriginEmbedderPolicyOptions,
 } from "./middlewares/cross-origin-embedder-policy/index.js";
 import crossOriginOpenerPolicy, {
-  CrossOriginOpenerPolicyOptions,
+  type CrossOriginOpenerPolicyOptions,
 } from "./middlewares/cross-origin-opener-policy/index.js";
 import crossOriginResourcePolicy, {
-  CrossOriginResourcePolicyOptions,
+  type CrossOriginResourcePolicyOptions,
 } from "./middlewares/cross-origin-resource-policy/index.js";
 import originAgentCluster from "./middlewares/origin-agent-cluster/index.js";
 import referrerPolicy, {
-  ReferrerPolicyOptions,
+  type ReferrerPolicyOptions,
 } from "./middlewares/referrer-policy/index.js";
 import strictTransportSecurity, {
-  StrictTransportSecurityOptions,
+  type StrictTransportSecurityOptions,
 } from "./middlewares/strict-transport-security/index.js";
 import xContentTypeOptions from "./middlewares/x-content-type-options/index.js";
 import xDnsPrefetchControl, {
-  XDnsPrefetchControlOptions,
+  type XDnsPrefetchControlOptions,
 } from "./middlewares/x-dns-prefetch-control/index.js";
 import xDownloadOptions from "./middlewares/x-download-options/index.js";
 import xFrameOptions, {
-  XFrameOptionsOptions,
+  type XFrameOptionsOptions,
 } from "./middlewares/x-frame-options/index.js";
 import xPermittedCrossDomainPolicies, {
-  XPermittedCrossDomainPoliciesOptions,
+  type XPermittedCrossDomainPoliciesOptions,
 } from "./middlewares/x-permitted-cross-domain-policies/index.js";
 import xPoweredBy from "./middlewares/x-powered-by/index.js";
 import xXssProtection from "./middlewares/x-xss-protection/index.js";

middlewares/content-security-policy/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 type ContentSecurityPolicyDirectiveValueFunction = (
   req: IncomingMessage,

middlewares/cross-origin-embedder-policy/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface CrossOriginEmbedderPolicyOptions {
   policy?: "require-corp" | "credentialless";

middlewares/cross-origin-opener-policy/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface CrossOriginOpenerPolicyOptions {
   policy?: "same-origin" | "same-origin-allow-popups" | "unsafe-none";

middlewares/cross-origin-resource-policy/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface CrossOriginResourcePolicyOptions {
   policy?: "same-origin" | "same-site" | "cross-origin";

middlewares/origin-agent-cluster/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 function originAgentCluster() {
   return function originAgentClusterMiddleware(

middlewares/referrer-policy/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 type ReferrerPolicyToken =
   | "no-referrer"

middlewares/strict-transport-security/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 const DEFAULT_MAX_AGE = 180 * 24 * 60 * 60;
 

middlewares/x-content-type-options/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 function xContentTypeOptions() {
   return function xContentTypeOptionsMiddleware(

middlewares/x-dns-prefetch-control/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface XDnsPrefetchControlOptions {
   allow?: boolean;

middlewares/x-download-options/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 function xDownloadOptions() {
   return function xDownloadOptionsMiddleware(

middlewares/x-frame-options/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface XFrameOptionsOptions {
   action?: "deny" | "sameorigin";

middlewares/x-permitted-cross-domain-policies/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 export interface XPermittedCrossDomainPoliciesOptions {
   permittedPolicies?: "none" | "master-only" | "by-content-type" | "all";

middlewares/x-powered-by/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 function xPoweredBy() {
   return function xPoweredByMiddleware(

middlewares/x-xss-protection/index.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 
 function xXssProtection() {
   return function xXssProtectionMiddleware(

test/helpers.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 import connect from "connect";
 import supertest from "supertest";
 

test/index.test.ts

@@ -1,4 +1,4 @@
-import { IncomingMessage, ServerResponse } from "http";
+import type { IncomingMessage, ServerResponse } from "http";
 import { check } from "./helpers";
 import connect from "connect";
 import supertest from "supertest";