Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.1.0 #245

Merged
merged 5 commits into from
Aug 15, 2020
Merged

Release v4.1.0 #245

merged 5 commits into from
Aug 15, 2020

Conversation

EvanHahn
Copy link
Member

@EvanHahn EvanHahn commented Aug 10, 2020

Expected release date: 2020-08-15

Try this out with npm install helmet@4.1.0-rc.2.

Read the changelog to see what changed.

Closes #235.
Closes #243.

This was removed in Helmet 4, which I regret. You can read more about it
on [this GitHub issue][0].

Closes [#243][0].

[0]: #243
@anthony-telljohann
Copy link

@EvanHahn After installing helmet@4.1.0-rc.2, I was able to fix the typescript errors by importing the default export:

import helmet from 'helmet'
app.use(helmet(helmetConfig))

@EvanHahn
Copy link
Member Author

@anthony-telljohann I assume that's a good thing, but let me know if that's not ideal for you.

@anthony-telljohann
Copy link

It's a good thing. Looking forward to the release!

@EvanHahn EvanHahn merged commit 897a06f into master Aug 15, 2020
@EvanHahn EvanHahn deleted the v4.1.0 branch August 15, 2020 14:12
@EvanHahn
Copy link
Member Author

This has been released!

@kytrongchinh
Copy link

Hi @EvanHahn
I installed with version helmet@4.1.0-rc.2 and run it on Nodejs version 10.15.3
But I just still got the same error
image

My site just working when I install with version 3.23.3

@EvanHahn
Copy link
Member Author

@kytrongchinh This is happening because Helmet 4 sets a default Content Security Policy. See this section of the upgrade guide for help.

Also: you no longer need to install the release candidate. Helmet v4.1.0 has been released.

@kytrongchinh
Copy link

Thank @EvanHahn so much!
The reason that is not noted on the document, so I and more dev use helmet have problems.

// This disables the contentSecurityPolicy middleware but keeps the rest.
app.use(
helmet({
contentSecurityPolicy: false,
})
);
Good for noted, Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Content-Security-Policy: reimplement directive values as functions Issues with TypeScript imports in 4.0.0
3 participants