Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put max age first in expect-ct middleware #264

Merged
merged 1 commit into from Sep 28, 2020
Merged

put max age first in expect-ct middleware #264

merged 1 commit into from Sep 28, 2020

Conversation

CyberZujo
Copy link
Contributor

Updated expect-ct -> getHeaderValueFromOptions method where there was necessary to put max-age property as first in directives.

Updated expect-ct.test.ts

EvanHahn
EvanHahn approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I plan to merge this soon.

@EvanHahn EvanHahn merged commit dd29cf4 into helmetjs:master Sep 28, 2020
@EvanHahn EvanHahn mentioned this pull request Sep 28, 2020
Closed
@EvanHahn
Copy link
Member

Thank you! I'll release this with the next version of Helmet.

Feel free to add yourself to the contributors list.

@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CyberZujo @EvanHahn