Fixing IE tests. Shows that tests still fail for 3780bf59 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @evilpacket / @EvanHahn Let me know if you want another pull request actually fixing the bug as well. |
EvanHahn
added a commit
that referenced
this pull request
Jun 4, 2014
Fixing IE tests. Shows that tests still fail for 3780bf5
EvanHahn
added a commit
that referenced
this pull request
Jun 4, 2014
|
I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you? I'll credit you for this PR and #44, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added here: 3780bf5
And some previous tests are broken. See this comment to see why: #44 (comment)