Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce DISABLE_INSECURE_FEATURES to disable insecure executions #1

Merged
merged 17 commits into from
Jun 5, 2022
Merged

introduce DISABLE_INSECURE_FEATURES to disable insecure executions #1

merged 17 commits into from
Jun 5, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Apr 3, 2022 •
edited

Related to roboll/helmfile#2080

Should we have DISABLE_INSECURE_TEMPLATING_FEATURES along with DISABLE_INSECURE_FEATURES? So that we can still have remote chart functionality?

  • Add unit tests

@itscaro itscaro marked this pull request as draft April 3, 2022 06:49
@mumoshu mumoshu force-pushed the main branch 2 times, most recently from a4a2f71 to 1aa8753 Compare April 3, 2022 07:25
@itscaro itscaro force-pushed the qtran/issue-2080 branch 2 times, most recently from 37fa1bf to f15ec99 Compare April 4, 2022 19:58
@itscaro itscaro marked this pull request as ready for review April 4, 2022 20:01
@itscaro itscaro requested a review from mumoshu as a code owner April 4, 2022 20:01
mumoshu
mumoshu reviewed Apr 4, 2022
View reviewed changes
pkg/tmpl/context_funcs.go Outdated Show resolved Hide resolved
@itscaro itscaro force-pushed the qtran/issue-2080 branch 3 times, most recently from e68ea48 to 9af12df Compare April 11, 2022 21:26
itscaro
itscaro commented Apr 11, 2022
View reviewed changes
pkg/envvar/const.go
@@ -0,0 +1,8 @@
package envvar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to centralise all HELMFILE_* envvar

@itscaro itscaro force-pushed the qtran/issue-2080 branch 2 times, most recently from 9a4cfb4 to cfba4fb Compare April 11, 2022 21:31
@itscaro itscaro requested review from mumoshu, renehernandez and a team April 11, 2022 21:31
@mumoshu
Copy link
Contributor

mumoshu commented Apr 13, 2022

Some tests seem to be failing due to additional logs(I thought there were several tests that checks for the log output

@itscaro
Copy link
Contributor Author

itscaro commented Apr 14, 2022

@mumoshu I will check asap

@itscaro
introduce DISABLE_INSECURE_FEATURES to disable insecure executions
5b1ed5b 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro
disable remote sources when DISABLE_INSECURE_FEATURES is set to "true"
7c3e131 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro
refactor envvar package
0c8cc1f 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro itscaro force-pushed the qtran/issue-2080 branch 2 times, most recently from 0a6d98b to ac92004 Compare April 21, 2022 22:40
@itscaro
(test) fix test fixtures
03248b7 
Signed-off-by: Quan TRAN <account@itscaro.me>
@stale stale bot removed the wontfix This will not be worked on label May 9, 2022
@itscaro
use absolute path to avoid unit test failure
22062e6 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro
Copy link
Contributor Author

itscaro commented May 10, 2022

@mumoshu I finally have some time to fix unit tests ;-)

@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 30, 2022
@mumoshu mumoshu removed the wontfix This will not be worked on label May 31, 2022
@mumoshu
Copy link
Contributor

mumoshu commented May 31, 2022

Tried my best to fix conflits

mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/app/app_test.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/helmexec/exec.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/app/constants.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/app/constants_test.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/helmexec/exec_test.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/remote/remote.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
pkg/state/temp.go Outdated Show resolved Hide resolved
mumoshu
mumoshu reviewed Jun 5, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
mumoshu
mumoshu approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itscaro!

@mumoshu mumoshu merged commit 577f54a into helmfile:main Jun 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
@itscaro itscaro deleted the qtran/issue-2080 branch June 15, 2022 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@renehernandez renehernandez Awaiting requested review from renehernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itscaro @mumoshu