optimize flag logic about wait #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumoshu Regarding configuration priorities, I feel like we should make some decisions. It's a little unclear at the moment. WDYT? |
|
@yxxhero There was a lack of test cases here before, we should add them this time. WDYT? |
|
@xiaomudk I think so. |
Signed-off-by: yxxhero <aiopsclub@163.com>
yxxhero
force-pushed
the
optimize-flag-logic
branch
from
fab4025
to
a0bade5
Compare
xiaomudk
reviewed
Oct 19, 2023
pkg/state/helmx_test.go
Outdated
| }{ | ||
| { | ||
| name: "release wait for jobs", | ||
| release: &ReleaseSpec{WaitForJobs: &[]bool{true, true}[0]}, |
pkg/state/helmx_test.go
Outdated
| }, | ||
| { | ||
| name: "release wait for jobs false", | ||
| release: &ReleaseSpec{WaitForJobs: &[]bool{false, false}[0]}, |
pkg/state/helmx_test.go
Outdated
| }{ | ||
| { | ||
| name: "release wait", | ||
| release: &ReleaseSpec{Wait: &[]bool{true, true}[0]}, |
pkg/state/helmx_test.go
Outdated
| }, | ||
| { | ||
| name: "release wait false", | ||
| release: &ReleaseSpec{Wait: &[]bool{false, false}[0]}, |
Signed-off-by: yxxhero <aiopsclub@163.com>
xiaomudk
approved these changes
Oct 19, 2023
JadeHayes
pushed a commit
to Secretions/helmfile
that referenced
this pull request
Dec 7, 2023
* optimize flag logic about wait Signed-off-by: yxxhero <aiopsclub@163.com> * fix tests Signed-off-by: yxxhero <aiopsclub@163.com> * add units Signed-off-by: yxxhero <aiopsclub@163.com> * fix little issues Signed-off-by: yxxhero <aiopsclub@163.com> --------- Signed-off-by: yxxhero <aiopsclub@163.com> Signed-off-by: Jade Hayes <jade.hayes@dominodatalab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize flag logic about wait