Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for HELMFILE_FILE_PATH envvar to set -f #1255

Merged
merged 2 commits into from
Jan 3, 2024
Merged

add support for HELMFILE_FILE_PATH envvar to set -f #1255

merged 2 commits into from
Jan 3, 2024

Conversation

sstarcher
Copy link
Contributor

@sstarcher sstarcher force-pushed the feature/helmfile-path branch 2 times, most recently from 6d4a42a to 4c22e25 Compare December 27, 2023 12:36
@sstarcher sstarcher changed the title add support for HELMFILE_FILE_PATH envvar to set -f add support for HELMFILE_FILE_PATH envvar to set -f Dec 27, 2023
@sstarcher
Copy link
Contributor Author

Any way to rekick off the tests as they don't look related to my change. If not I can amend and push the commit back up.

@yxxhero
Copy link
Member

yxxhero commented Dec 28, 2023

@sstarcher please add some tests for this feature. thanks so much.

@sstarcher sstarcher force-pushed the feature/helmfile-path branch 2 times, most recently from 2bd5d9b to 328609e Compare December 28, 2023 12:29
@yxxhero
Copy link
Member

yxxhero commented Dec 30, 2023

@sstarcher please fix lint error.

@sstarcher
Copy link
Contributor Author

@yxxhero not seeing any errors output in those logs. Looks unrelated to me

run golangci-lint
  Running [/home/runner/golangci-lint-1.55.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/helmfile/helmfile) (gci)
  Error: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/helmfile/helmfile) (gci)
  
  Error: issues found
  Ran golangci-lint in 5361ms

@yxxhero
Copy link
Member

yxxhero commented Jan 2, 2024

@yxxhero not seeing any errors output in those logs. Looks unrelated to me

run golangci-lint
  Running [/home/runner/golangci-lint-1.55.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/helmfile/helmfile) (gci)
  Error: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/helmfile/helmfile) (gci)
  
  Error: issues found
  Ran golangci-lint in 5361ms

you should order your go imports. @sstarcher

@sstarcher
Copy link
Contributor Author

@yxxhero thanks for the fix. Anything else needed to get this merged?

@sstarcher
fix imports
0ad875f 
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
@sstarcher
unset env var
043cb33 
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
@yxxhero yxxhero merged commit d681c62 into helmfile:main Jan 3, 2024
14 checks passed
@sstarcher
Copy link
Contributor Author

Thanks

@sstarcher sstarcher deleted the feature/helmfile-path branch January 3, 2024 13:38
@BrewTestBot BrewTestBot mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

@xiaomudk xiaomudk Awaiting requested review from xiaomudk xiaomudk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sstarcher @yxxhero