fix checker error message #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: petelock <pete2387@gmail.com>
petelock
force-pushed
the
fix-key-order-error-msg
branch
from
f6ee118
to
8e84181
Compare
petelock
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
|
@petelock good work. thanks so much. |
yxxhero
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the error message thrown when keys are in the wrong order provides the reverse error message to which it should be giving. This PR simply switches the format inputs of the provided error message (no unit tests affected). This gave me a few headaches until I worked through the logic of the code manually and noticed the bug in the error message 馃槃
Simplified Helmfile example:
Current error message provided when running a Helmfile command, e.g.
helmfile diff: