Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yxxhero as a maintainer #132

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Add yxxhero as a maintainer #132

merged 1 commit into from
Jun 5, 2022

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Jun 5, 2022

I've asked a few times by @yxxhero if he deserves a seat as a maintainer of the Helmfile project.
Seeing the amount and the number of his recent contributions, and the nature of his contributions (add tests and fix bugs and CI issues, review PRs), I think he is in a relatively unique position compared to existing maintainers, and we can work better together!

@itscaro WDYT?

@mumoshu mumoshu requested a review from itscaro as a code owner June 5, 2022 06:27
I've asked a few times by @yxxhero if he deserves a seat as a maintainer of the Helmfile project.
Seeing the amount and the number of his recent contributions, and the nature of his contributions (add tests and fix bugs and CI issues, review PRs), I think he is in a relatively unique position compared to existing maintainers, and we can work better together!

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
@mumoshu mumoshu force-pushed the add-yxxhero-as-a-maintainer branch from 9977e9e to 7ae20e3 Compare June 5, 2022 06:31
Copy link
Contributor

@itscaro itscaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on board @yxxhero

@yxxhero
Copy link
Member

yxxhero commented Jun 5, 2022

@mumoshu @itscaro Thanks very much. It's my pleasure.

@mumoshu
Copy link
Contributor Author

mumoshu commented Jun 5, 2022

Welcome @yxxhero 🎉

@mumoshu mumoshu merged commit 58721ab into main Jun 5, 2022
@mumoshu mumoshu deleted the add-yxxhero-as-a-maintainer branch June 5, 2022 07:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants