Add proposals about two breaking changes before we cut Helmfile 1.0 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
|
@mumoshu It's very good. I like those ideas. |
yxxhero
approved these changes
Jun 5, 2022
|
@mumoshu The project introduces many closure logic and functions as parameters, which is not easy to read. WDYT? |
|
@yxxhero We can defer any major refactorings to post-1.0 as long as they don't incur breaking changes(and they shouldn't) but anyway, do you have any better ideas? Closures are used as a way to consistently apply all the pre/post conditions to the main logic for each helmfile sub-command. My take was that they're there for reasons, but I'm definitely open to ideas for improvements! |
|
@mumoshu That's it for now. It will be optimized in the future |
|
@mumoshu What is the detailed plan for 1.0, and what part can I participate in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@itscaro @yxxhero I have some ideas about how we proceed to 1.0. WDYT?
// BTW, once we reach 1.0, I have an idea to make the user experience of writing and reading helmfile configs more great, by using Starlark as the basis for Helmfile config syntax 馃槂 Following the policy described in this proposal, it will be added as a secondary config syntax and we'll keep current yaml+gotemplate based syntax as is, at least while in 1.x.