Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated chart in Getting Started #140

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

ogugu9
Copy link

@ogugu9 ogugu9 commented Jun 6, 2022

stable/prometheus is DEPRECATED and moved to prometheus-community/prometheus.
see https://github.com/helm/charts/blob/master/stable/prometheus/README.md?plain=1#L3

So, I fixed "Getting Started" in README.md.

@yxxhero
Copy link
Member

yxxhero commented Jun 6, 2022

@ogugu9 Please fix DCO issue in ci. Thanks very much.

Signed-off-by: ogugu (Riku Ogura) <e.cos.isin@gmail.com>
@ogugu9 ogugu9 force-pushed the fix-getting-started-chart branch from f5de956 to c897a10 Compare June 6, 2022 11:59
@ogugu9
Copy link
Author

ogugu9 commented Jun 6, 2022

@yxxhero sorry, I fixed!

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yxxhero
Copy link
Member

yxxhero commented Jun 6, 2022

@ogugu9 Thanks for your PR. you can find more in discussions. example good first issue.

@yxxhero yxxhero merged commit e182e9e into helmfile:main Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants