Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump module Go version to 1.18 #150

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Bump module Go version to 1.18 #150

merged 1 commit into from
Jun 10, 2022

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Jun 10, 2022

Our CI workflows and docker builds already use 1.18 but our go.mod was left with 1.17. This bumps it to 1.18.

I also ran go mod tidy to see if there might be redundant entries in go.mod and go.sum, and also if it doesn't change go.mod and go.sum significantly. Apparently, there seem like redundant historical dependencies recorded in go.sum being removed.

@yxxhero
Copy link
Member

yxxhero commented Jun 10, 2022

@mumoshu DCO. I often forget too.

Our CI workflows and docker builds already use 1.18 but our go.mod was left with 1.17. This bumps it to 1.18.

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yxxhero yxxhero merged commit 261b311 into main Jun 10, 2022
@yxxhero yxxhero deleted the go-1.18 branch June 10, 2022 02:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants