Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci test error #167

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix ci test error #167

merged 1 commit into from
Jun 21, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Jun 19, 2022

Signed-off-by: yxxhero aiopsclub@163.com

fix ci test error

make build build-test-tools
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.18.[3](https://github.com/helmfile/helmfile/runs/6953513978?check_suite_focus=true#step:6:3)/x6[4](https://github.com/helmfile/helmfile/runs/6953513978?check_suite_focus=true#step:6:4)
fatal: No names found, cannot describe anything.
go build -ldflags '-X github.com/helmfile/helmfile/pkg/app/version.Version=' 
go build test/diff-yamls/diff-yamls.go
go build test/yamldiff/yamldiff.go

version is nil

Signed-off-by: yxxhero <aiopsclub@163.com>
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! It's much better now. Thanks.

CleanShot 2022-06-21 at 10 51 23@2x

(Ideally, this should be something like 0.144.0+dirty or 0.144.0+unreleased or anything that isn't exactly the same as the latest, already-released helmfile version but that might be just a nice-to-have

@mumoshu mumoshu merged commit 1996304 into helmfile:main Jun 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants