Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] unclosed file stream when creating temporary decrypted files #20

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[fix] unclosed file stream when creating temporary decrypted files #20

merged 1 commit into from
Apr 5, 2022

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Apr 5, 2022

@itscaro
[fix] unclosed file stream when creating temporary decrypted files
a793797 
Signed-off-by: Quan TRAN <account@itscaro.me>
@itscaro itscaro requested a review from mumoshu as a code owner April 5, 2022 20:52
mumoshu
mumoshu approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks a lot for fixing it. I had no idea what's causing this 🙏

@mumoshu mumoshu merged commit f49d181 into helmfile:main Apr 5, 2022
@itscaro itscaro deleted the qtran/fix-decrypted-file branch April 6, 2022 06:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to delete decrypted files on Windows results in PathError
2 participants
@itscaro @mumoshu